Update expression and anomaly detector documentation #8041

kkondaka · 2024-08-16T21:18:39Z

Description

Data Prepper supports arithmetic operators but the documentation is not updated to reflect that.
Also, Random Cut forest in anomaly detector processor support a new option which is not reflected in the documentation.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kondaka <[email protected]>

github-actions · 2024-08-16T21:18:50Z

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

_data-prepper/pipelines/expression-syntax.md

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

vagimeli

@kkondaka Doc review completed. Please see the writing edits for clarity and conciseness. Once these changes are approved, I'll move this PR into editorial and then merge it.

_data-prepper/pipelines/configuration/processors/anomaly-detector.md

_data-prepper/pipelines/expression-syntax.md

vagimeli · 2024-08-19T15:44:25Z

_data-prepper/pipelines/expression-syntax.md

+```
+{% include copy-curl.html %}
+
+The following are some example arithmetic expressions used in conditional expressions : 


Suggested change

The following are some example arithmetic expressions used in conditional expressions :

The following are example arithmetic expressions that can be used in conditional expressions:

_data-prepper/pipelines/expression-syntax.md

vagimeli · 2024-08-22T15:00:06Z

@dlvenable I've completed the doc review and accepted your edits and comments. I also edited text for readability and style. Please review and approve at your availability, and then I'll move this forward for publishing. Thank you.

vagimeli · 2024-10-16T00:29:03Z

@dlvenable I've completed the doc review and accepted your edits and comments. I also edited text for readability and style. Please review and approve at your availability, and then I'll move this forward for publishing. Thank you.

@kkondaka @vagimeli Doc review is complete and ready for your approval. Thanks!

vagimeli · 2024-11-01T15:05:19Z

@dlvenable I've completed the doc review and accepted your edits and comments. I also edited text for readability and style. Please review and approve at your availability, and then I'll move this forward for publishing. Thank you.

@kkondaka @vagimeli Doc review is complete and ready for your approval. Thanks!

@kkondaka Please provide a status update for this PR. It's awaiting your acceptance of my doc review changes and @dlvenable approval. Thank you.

vagimeli · 2024-11-13T19:19:20Z

@dlvenable I've completed the doc review and accepted your edits and comments. I also edited text for readability and style. Please review and approve at your availability, and then I'll move this forward for publishing. Thank you.

@kkondaka @vagimeli Doc review is complete and ready for your approval. Thanks!

@kkondaka Please provide a status update for this PR. It's awaiting your acceptance of my doc review changes and @dlvenable approval. Thank you.

@kkondaka @dlvenable Please provide a status update for this PR. It's awaiting your acceptance of my doc review changes and @dlvenable approval. Thank you.

Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Review feedback implemented

Naarcha-AWS · 2024-12-03T16:01:31Z

Reviewed this once again, looks like the original tech review by David was implemented. Dismissed his review and added Melissa's doc review. Merging now.

* Update expression and anomaly detector documentation Signed-off-by: Kondaka <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _data-prepper/pipelines/expression-syntax.md Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Apply suggestions from code review Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Kondaka <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: David Venable <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 9bd4c42) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Update expression and anomaly detector documentation

2178906

Signed-off-by: Kondaka <[email protected]>

kkondaka requested review from kolchfa-aws, Naarcha-AWS, vagimeli, AMoo-Miki, natebower, dlvenable, stephen-crawford and epugh as code owners August 16, 2024 21:18

github-actions bot assigned kolchfa-aws Aug 16, 2024

dlvenable previously requested changes Aug 16, 2024

View reviewed changes

kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Aug 16, 2024

vagimeli and others added 5 commits August 19, 2024 09:51

Update _data-prepper/pipelines/expression-syntax.md

12ea363

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

Update _data-prepper/pipelines/expression-syntax.md

60b4977

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

Update _data-prepper/pipelines/expression-syntax.md

3fbd722

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

Update _data-prepper/pipelines/expression-syntax.md

d442ceb

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

Update _data-prepper/pipelines/expression-syntax.md

b0c9fc4

Co-authored-by: David Venable <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>

vagimeli approved these changes Aug 19, 2024

View reviewed changes

Merge branch 'main' into expr-doc-fix

3e86e12

vagimeli added the 3 - Tech review PR: Tech review in progress label Aug 22, 2024

Merge branch 'main' into expr-doc-fix

8730369

vagimeli added Needs SME Waiting on input from subject matter expert 3 - Tech review PR: Tech review in progress and removed 3 - Tech review PR: Tech review in progress labels Aug 29, 2024

vagimeli added data-prepper and removed 3 - Tech review PR: Tech review in progress labels Oct 9, 2024

Merge branch 'main' into expr-doc-fix

2d870c9

Merge branch 'main' into expr-doc-fix

10ee243

Merge branch 'main' into expr-doc-fix

578a6a2

Merge branch 'main' into expr-doc-fix

9b37a75

vagimeli added the 3 - Tech review PR: Tech review in progress label Nov 13, 2024

kolchfa-aws assigned Naarcha-AWS and unassigned vagimeli Dec 2, 2024

Naarcha-AWS and others added 2 commits December 3, 2024 09:59

Merge branch 'main' into expr-doc-fix

abebfd2

Apply suggestions from code review

d1a346b

Co-authored-by: Melissa Vagi <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>

Naarcha-AWS requested a review from dlvenable December 3, 2024 16:00

Naarcha-AWS added backport 2.18 PR: Backport label for 2.18 and removed 3 - Tech review PR: Tech review in progress labels Dec 3, 2024

Naarcha-AWS merged commit 9bd4c42 into opensearch-project:main Dec 3, 2024
6 checks passed

opensearch-trigger-bot bot mentioned this pull request Dec 3, 2024

[Backport 2.18] Update expression and anomaly detector documentation #8865

Merged

github-actions bot pushed a commit that referenced this pull request Dec 3, 2024

Update expression and anomaly detector documentation (#8041) (#8865)

4f02404

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update expression and anomaly detector documentation #8041

Update expression and anomaly detector documentation #8041

kkondaka commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

vagimeli left a comment •

edited

Loading

vagimeli Aug 19, 2024

vagimeli commented Aug 22, 2024

vagimeli commented Oct 16, 2024

vagimeli commented Nov 1, 2024

vagimeli commented Nov 13, 2024

Naarcha-AWS commented Dec 3, 2024

	The following are some example arithmetic expressions used in conditional expressions :
	The following are example arithmetic expressions that can be used in conditional expressions:

Update expression and anomaly detector documentation #8041

Update expression and anomaly detector documentation #8041

Conversation

kkondaka commented Aug 16, 2024

Description

Issues Resolved

Version

Frontend features

Checklist

github-actions bot commented Aug 16, 2024

vagimeli left a comment • edited Loading

Choose a reason for hiding this comment

vagimeli Aug 19, 2024

Choose a reason for hiding this comment

vagimeli commented Aug 22, 2024

vagimeli commented Oct 16, 2024

vagimeli commented Nov 1, 2024

vagimeli commented Nov 13, 2024

Naarcha-AWS commented Dec 3, 2024

vagimeli left a comment •

edited

Loading