Add General Guidelines for concurrent segment search #7402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
sohami
reviewed
Jun 17, 2024
Signed-off-by: Jay Deng <[email protected]>
sohami
approved these changes
Jun 17, 2024
|
@hdhalter @kolchfa-aws I didn't open an issue for this and instead directly created the PR, let me know if you would like me to open an issue as well. Thanks! |
|
@jed326 That's fine, thanks. No issue needed. I will review shortly. |
kolchfa-aws
reviewed
Jun 21, 2024
kolchfa-aws
reviewed
Jun 21, 2024
kolchfa-aws
reviewed
Jun 21, 2024
kolchfa-aws
reviewed
Jun 21, 2024
kolchfa-aws
reviewed
Jun 21, 2024
kolchfa-aws
approved these changes
Jun 25, 2024
natebower
reviewed
Jun 25, 2024
There was a problem hiding this comment.
@kolchfa-aws I edited your suggestions. LGTM as they are now. Thanks!
Signed-off-by: kolchfa-aws <[email protected]>
Naarcha-AWS
added
backport 2.15
and removed
backport 2.14
|
Hey @Naarcha-AWS / @kolchfa-aws are you able to give a rough ETA of when this change will be able to be merged and pushed live on the documentation website? I'm looking to post a blog entry about concurrent search soon and would like to be able to reference this new section. Thanks! |
|
Thanks for the reminder, @jed326! Merging now 🚢 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Add General Guidelines for concurrent segment search Signed-off-by: Jay Deng <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Jay Deng <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit 1c3119b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
…ect#7402) * Add General Guidelines for concurrent segment search Signed-off-by: Jay Deng <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Jay Deng <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: [email protected] <[email protected]>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
…ect#7402) * Add General Guidelines for concurrent segment search Signed-off-by: Jay Deng <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Jay Deng <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add General Guidelines for concurrent segment search
Version
2.12+
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.