-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding explanation to jwks validation #7367 #20240522 #7398
Merged
Naarcha-AWS
merged 3 commits into
opensearch-project:main
from
AntonEliatra:updating-jwt-example
Jun 25, 2024
Merged
adding explanation to jwks validation #7367 #20240522 #7398
Naarcha-AWS
merged 3 commits into
opensearch-project:main
from
AntonEliatra:updating-jwt-example
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
June 17, 2024 14:20
stephen-crawford
approved these changes
Jun 24, 2024
hdhalter
added
4 - Doc review
PR: Doc review in progress
and removed
3 - Tech review
PR: Tech review in progress
labels
Jun 24, 2024
Naarcha-AWS
reviewed
Jun 25, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
approved these changes
Jun 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* adding explanation to jwks validation #7367 #20240522 Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 37e451b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
hdhalter
added
3 - Done
Issue is done/complete
and removed
4 - Doc review
PR: Doc review in progress
labels
Jun 25, 2024
Naarcha-AWS
added
backport 2.15
and removed
backport 2.14
PR: Backport label for 2.14
labels
Jun 26, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-7398-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37e451b72d49588b6e081d20c69f588d080e57b7
# Push it to GitHub
git push --set-upstream origin backport/backport-7398-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15 Then, create a pull request where the |
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
…22 (opensearch-project#7398) * adding explanation to jwks validation opensearch-project#7367 #20240522 Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding explanation to jwks validation
Issues Resolved
#7367
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.