-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache plugin and tiered cache documentation #7052
Merged
Naarcha-AWS
merged 50 commits into
opensearch-project:main
from
sgup432:tiered_cache_doc2
May 8, 2024
Merged
Add cache plugin and tiered cache documentation #7052
Naarcha-AWS
merged 50 commits into
opensearch-project:main
from
sgup432:tiered_cache_doc2
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgup432
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
April 29, 2024 22:53
hdhalter
added
4 - Doc review
PR: Doc review in progress
release-notes
PR: Include this PR in the automated release notes
v2.14.0
labels
Apr 30, 2024
Thanks, @sgup432 ! |
Naarcha-AWS
requested changes
May 2, 2024
Naarcha-AWS
approved these changes
May 6, 2024
Naarcha-AWS
reviewed
May 7, 2024
Naarcha-AWS
reviewed
May 7, 2024
Naarcha-AWS
added
5 - Editorial review
PR: Editorial review in progress
and removed
4 - Doc review
PR: Doc review in progress
labels
May 8, 2024
natebower
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgup432 @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!
4 tasks
jainankitk
approved these changes
May 8, 2024
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
I messed up a bit(other commits are added to this PR) trying to fix DCO check. Fixing it now. |
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@natebower I have addressed your comments. Looks good to me. |
Naarcha-AWS
reviewed
May 8, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
hdhalter
added
3 - Done
Issue is done/complete
experimental
and removed
5 - Editorial review
PR: Editorial review in progress
labels
May 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Done
Issue is done/complete
experimental
release-notes
PR: Include this PR in the automated release notes
v2.14.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new doc for cache plugins introduced as part of 2.14.
Also adding a doc for tiered cache which is one of the implementation provided via cache plugin.
Note: This is an experimental feature.
Issues Resolved
Closes #6300
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.