Remove ingest processor supports excluding fields #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
vagimeli
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
@gaobinlong Please see the doc review edits. I'll move this into editorial once changes are made. Thank you!
hdhalter
added
release-notes
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added
5 - Editorial review
natebower
reviewed
Jan 26, 2024
| @@ -30,7 +30,8 @@ The following table lists the required and optional parameters for the `remove` | |||
|
|
|||
| | Parameter | Required/Optional | Description | | |||
| |---|---|---| | |||
| `field` | Required | The name of the field containing the data to be removed. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). The following metadata fields are not allowed to be removed: `_index`, `_version`, `_version_type`, and `_id`. Note that `_id` is not allowed to be removed when there's a specified external version for the ingesting document. | | |||
| `field` | Optional | The field name containing the data to be removed. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). The following metadata fields cannot be removed: `_index`, `_version`, `_version_type`, and `_id`. If a version is specified for the ingesting document, the `_id` cannot be removed. | | |||
There was a problem hiding this comment.
As written, "ingesting document" implies that the document is ingesting something. Is this accurate, or should we reword?
There was a problem hiding this comment.
Revised: The metadata fields _index, _version, _version_type, and _idcannot be removed. Ifversionis specified,_id cannot be removed from the ingested document.
vagimeli
added
3 - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remove ingest processor will support excluding fields in version 2.12.0, a new parameter
exclude_filedis added to that processor, this PR updates the remove processor's document to add the parameter.Issues Resolved
Fixes #5918
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.