-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add set processor documentation #5989
Conversation
Signed-off-by: Melissa Vagi <[email protected]>
@hdhalter We need a dev to take the first pass at drafting this content. I can support them in refining the content and getting it through the documentation process. The ingest processor template is provided with this PR, so it should help the dev get started. Thanks! |
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@gaobinlong This PR is ready for your review at your availability. Thank you for all your technical reviews on these topics! |
Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
_ingest-pipelines/processors/set.md
Outdated
|
||
# Set processor | ||
|
||
The `set` processor adds or updates fields in a document. It sets one field and associates it with the specified value. If the field already exists, its value is replaced with the provided one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the field already exists, its value is replaced with the provided one
This is not always true, because if the parameter override
is set to false and the specified field exists, the value of the field will not change.
_ingest-pipelines/processors/set.md
Outdated
`field` | Required | The name of the field to be set or updated. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). | ||
`value` | Required | The value to be assigned to the field. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets). | ||
`overrideEnabled` | Optional | A Boolean flag that determines whether the processor should override the exisitng value of the field. | ||
`ignoreEmptyValue` | Optional | A Boolean flag that determines whether the processor should ignore empty values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignoreEmptyValue
should be ignore_empty_value
, defaults to false, empty value means null
or empty string.
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli Please see my changes and let me know if you have any questions. Thanks!
Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
@natebower Thank you for the thorough review. I've accepted your edits. Will you approve for merging? This is part of the series that I opened PRs and co-authored with dev, but can't approve. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add set processor documentation Signed-off-by: Melissa Vagi <[email protected]> * add text and examples Signed-off-by: Melissa Vagi <[email protected]> * add text and examples Signed-off-by: Melissa Vagi <[email protected]> * Update set.md Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 7df5fee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add set processor documentation Signed-off-by: Melissa Vagi <[email protected]> * add text and examples Signed-off-by: Melissa Vagi <[email protected]> * add text and examples Signed-off-by: Melissa Vagi <[email protected]> * Update set.md Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> * Update _ingest-pipelines/processors/set.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: RasonJ <[email protected]>
Description
Closes content gap
Issues Resolved
#4647
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.