Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation around keyword fields #5453

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented Oct 31, 2023

Description

Updated keyword field docs to mention doc values

Issues Resolved

Closes #5451

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws
Copy link
Collaborator

@harshavamsi What version is this for? Thanks!

@kolchfa-aws kolchfa-aws self-assigned this Oct 31, 2023
@harshavamsi
Copy link
Contributor Author

@kolchfa-aws this is for OS 2.12

@kolchfa-aws kolchfa-aws added v2.12.0 release-notes PR: Include this PR in the automated release notes labels Oct 31, 2023
@hdhalter
Copy link
Contributor

Fixes #5451

Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Contributor Author

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @harshavamsi!

@kolchfa-aws kolchfa-aws added the 6 - Done but waiting to merge PR: The work is done and ready to merge label Oct 31, 2023
@kolchfa-aws kolchfa-aws merged commit 103bb96 into opensearch-project:main Feb 1, 2024
3 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update documentation around keyword fields
3 participants