-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating documentation around keyword fields #5453
Merged
kolchfa-aws
merged 7 commits into
opensearch-project:main
from
harshavamsi:keyword_docvalues
Feb 1, 2024
Merged
Updating documentation around keyword fields #5453
kolchfa-aws
merged 7 commits into
opensearch-project:main
from
harshavamsi:keyword_docvalues
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
October 31, 2023 01:31
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
keyword_docvalues
branch
from
October 31, 2023 01:32
da6626f
to
9eb020a
Compare
7 tasks
@harshavamsi What version is this for? Thanks! |
@kolchfa-aws this is for OS 2.12 |
kolchfa-aws
added
v2.12.0
release-notes
PR: Include this PR in the automated release notes
labels
Oct 31, 2023
Fixes #5451 |
Signed-off-by: Fanit Kolchina <[email protected]>
harshavamsi
commented
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Fanit Kolchina <[email protected]>
…ion-website into keyword_docvalues
kolchfa-aws
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @harshavamsi!
kolchfa-aws
added
the
6 - Done but waiting to merge
PR: The work is done and ready to merge
label
Oct 31, 2023
Signed-off-by: kolchfa-aws <[email protected]>
hdhalter
added
3 - Done
Issue is done/complete
and removed
6 - Done but waiting to merge
PR: The work is done and ready to merge
labels
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Done
Issue is done/complete
release-notes
PR: Include this PR in the automated release notes
v2.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated keyword field docs to mention doc values
Issues Resolved
Closes #5451
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.