Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ml commons #5017

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Ml commons #5017

merged 14 commits into from
Sep 21, 2023

Conversation

dtaivpp
Copy link
Contributor

@dtaivpp dtaivpp commented Sep 13, 2023

Description

This PR does the following:

  1. Cleans up ML index page (related to [DOC] Machine Learning page re-write? #4869)
    • Previously the index page contained cluster settings and model permissions needed. These have been moved to the appropriate sections and are now referenced from the top page.
  2. Fixed code sample issue where incorrect sample was used for external connectors.
  3. Updated ML Cluster settings and ML Model Access pages to have appropriate data previously found in index page.

Issues Resolved

Closes opensearch-project/ml-commons#1332

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dtaivpp dtaivpp mentioned this pull request Sep 13, 2023
Closed
kolchfa-aws
kolchfa-aws approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of comments.

_ml-commons-plugin/cluster-settings.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws added 2 - In progress Issue/PR: The issue or PR is in progress. backport 2.9 PR: Backport label for 2.9 and removed untriaged labels Sep 20, 2023
@kolchfa-aws kolchfa-aws self-assigned this Sep 20, 2023
dtaivpp and others added 5 commits September 20, 2023 15:46
@dtaivpp @kolchfa-aws
Update _ml-commons-plugin/cluster-settings.md
1a2462f 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @kolchfa-aws
Update _ml-commons-plugin/index.md
bd87bc7 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @kolchfa-aws
Update _ml-commons-plugin/index.md
20198f7 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @kolchfa-aws
Update _ml-commons-plugin/index.md
390fffc 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @kolchfa-aws
Update _ml-commons-plugin/index.md
b0b00bf 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>
natebower
natebower reviewed Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtaivpp Just a few wording changes. Otherwise, LGTM!

_ml-commons-plugin/extensibility/connectors.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
_ml-commons-plugin/index.md Outdated Show resolved Hide resolved
dtaivpp and others added 2 commits September 21, 2023 12:07
@dtaivpp @natebower
Update _ml-commons-plugin/extensibility/connectors.md
ee90f23 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @natebower
Update _ml-commons-plugin/index.md
b5b4132 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp @natebower
Update _ml-commons-plugin/index.md
88a7e2c 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>
@dtaivpp
Copy link
Contributor Author

dtaivpp commented Sep 21, 2023

@natebower and @kolchfa-aws accepted all the changes, thank you for reviewing!

@hdhalter
Copy link
Contributor

@dtaivpp - Thank you for your bias for action in cleaning up this documentation! It is much appreciated.

@kolchfa-aws kolchfa-aws merged commit 2eb81a3 into opensearch-project:main Sep 21, 2023
3 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 21, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 21, 2023
@github-actions @kolchfa-aws @natebower
Ml commons (#5017)
a210d5b 
* Adding ML Node to cluster settings page

Signed-off-by: David Tippett <[email protected]>

* Removed Permissions and Cluster Settings from index; added roles to model access control

Signed-off-by: David Tippett <[email protected]>

* Referenced code sample was for local connector not external

Signed-off-by: David Tippett <[email protected]>

* Updated ML index page to refrence the order to get started with ML Commons.

Signed-off-by: David Tippett <[email protected]>

* Fixing style errors.

Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/extensibility/connectors.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

---------

Signed-off-by: David Tippett <[email protected]>
Signed-off-by: David Tippett <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 2eb81a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws added a commit that referenced this pull request Sep 21, 2023
@opensearch-trigger-bot @github-actions
@kolchfa-aws @natebower
Ml commons (#5017) (#5059)
dc2f727 
* Adding ML Node to cluster settings page



* Removed Permissions and Cluster Settings from index; added roles to model access control



* Referenced code sample was for local connector not external



* Updated ML index page to refrence the order to get started with ML Commons.



* Fixing style errors.



* Update _ml-commons-plugin/cluster-settings.md




* Update _ml-commons-plugin/index.md




* Update _ml-commons-plugin/index.md




* Update _ml-commons-plugin/index.md




* Update _ml-commons-plugin/index.md




* Update _ml-commons-plugin/extensibility/connectors.md




* Update _ml-commons-plugin/index.md




* Update _ml-commons-plugin/index.md




---------





(cherry picked from commit 2eb81a3)

Signed-off-by: David Tippett <[email protected]>
Signed-off-by: David Tippett <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
@dtaivpp @kolchfa-aws
@natebower @harshavamsi
Ml commons (opensearch-project#5017)
a67536f 
* Adding ML Node to cluster settings page

Signed-off-by: David Tippett <[email protected]>

* Removed Permissions and Cluster Settings from index; added roles to model access control

Signed-off-by: David Tippett <[email protected]>

* Referenced code sample was for local connector not external

Signed-off-by: David Tippett <[email protected]>

* Updated ML index page to refrence the order to get started with ML Commons.

Signed-off-by: David Tippett <[email protected]>

* Fixing style errors.

Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/extensibility/connectors.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

---------

Signed-off-by: David Tippett <[email protected]>
Signed-off-by: David Tippett <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
@dtaivpp @kolchfa-aws
@natebower @vagimeli
Ml commons (#5017)
0667d34 
* Adding ML Node to cluster settings page

Signed-off-by: David Tippett <[email protected]>

* Removed Permissions and Cluster Settings from index; added roles to model access control

Signed-off-by: David Tippett <[email protected]>

* Referenced code sample was for local connector not external

Signed-off-by: David Tippett <[email protected]>

* Updated ML index page to refrence the order to get started with ML Commons.

Signed-off-by: David Tippett <[email protected]>

* Fixing style errors.

Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/extensibility/connectors.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

* Update _ml-commons-plugin/index.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: David Tippett <[email protected]>

---------

Signed-off-by: David Tippett <[email protected]>
Signed-off-by: David Tippett <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@cwillum cwillum Awaiting requested review from cwillum

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
2 - In progress Issue/PR: The issue or PR is in progress. backport 2.9 PR: Backport label for 2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Examples of ML Remote Models
4 participants
@dtaivpp @hdhalter @natebower @kolchfa-aws