-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Guides sand SigV4 support guide #4997
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Hoang <[email protected]>
IanHoang
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
September 8, 2023 20:14
IanHoang
commented
Sep 8, 2023
_benchmark/guides/sigv4-support.md
Outdated
3. Invoke OSB like the command below. Ensure that you are specifying: | ||
|
||
- `--distribution-version` = This is needed because OSB parses the distribution version (usually provided or fetched from curling the cluster’s settings) and uses that to determine which OSB Workload branch to use. This can be 2.3.0 should be sufficient for now as it will use the workload branches that correlate to OpenSearch version 2.X | ||
- `--client-options=amazon_aws_log_in:environment` = tells OSB that you’ve exported the credentials in the environment in the previous step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will replace these =
signs with colons
Naarcha-AWS
requested changes
Sep 13, 2023
Naarcha-AWS
reviewed
Sep 13, 2023
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
reviewed
Sep 13, 2023
Signed-off-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Guides
section andSigv4 Support Guide
to OpenSearch Benchmark documentation.Issues Resolved
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.