Updating the K-NN Filters documentation due to recent enhancements in… #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
… Efficient Filters Signed-off-by: Navneet Verma <[email protected]>
hdhalter
added
release-notes
kolchfa-aws
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thanks very much, @navneet1v! Some minor wording and variable name suggestions.
Signed-off-by: Navneet Verma <[email protected]>
kolchfa-aws
reviewed
Sep 8, 2023
kolchfa-aws
reviewed
Sep 8, 2023
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Navneet Verma <[email protected]>
kolchfa-aws
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
LGTM. Thanks for making the changes, @navneet1v! I'll arrange for an editorial review and then the PR will be ready to merge.
kolchfa-aws
added
5 - Editorial review
natebower
reviewed
Sep 8, 2023
There was a problem hiding this comment.
@navneet1v @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
kolchfa-aws
reviewed
Sep 11, 2023
Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
added
6 - Done but waiting to merge
harshavamsi
pushed a commit
to harshavamsi/documentation-website
that referenced
this pull request
Oct 31, 2023
opensearch-project#4987) * Updating the K-NN Filters documentation due to recent enhancements in Efficient Filters Signed-off-by: Navneet Verma <[email protected]> * Fixed the review comments. Signed-off-by: Navneet Verma <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Navneet Verma <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Navneet Verma <[email protected]> * Update settings.md Signed-off-by: Navneet Verma <[email protected]> * Update _search-plugins/knn/settings.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
#4987) * Updating the K-NN Filters documentation due to recent enhancements in Efficient Filters Signed-off-by: Navneet Verma <[email protected]> * Fixed the review comments. Signed-off-by: Navneet Verma <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Navneet Verma <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Navneet Verma <[email protected]> * Update settings.md Signed-off-by: Navneet Verma <[email protected]> * Update _search-plugins/knn/settings.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the K-NN Filters documentation due to recent enhancements in Efficient Filters
Issues Resolved
Fixes #4962
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.