Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation that supports custom log types #4969
Add documentation that supports custom log types #4969
Changes from 27 commits
4b87dfc
f49a578
77931c2
bf8020e
6b9912b
4f43a9b
9d4f9db
10a5a58
b17657b
cf15866
5f09eeb
1669fee
3383f9f
60fc156
461a7e8
3107ae6
0a70c29
6f09205
8c0fb6e
02ef654
db25a9e
829ab68
f5210c3
d443444
0134802
9eae221
8969c9c
0833900
9f54189
0154048
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this note format correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is DNS lowercased and bolded in this context? Is it supposed to match a UI element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But this representation is opposed by the PM. UX and front-end dev will eventually replace these log type names with revised names. For the time being, this is the way the log type is represented in the UI.