Add new documentation IP2Geo processor automatic updating feature #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vagimeli <[email protected]>
vagimeli
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
Signed-off-by: vagimeli <[email protected]>
Closed
4 tasks
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
vagimeli
added
3 - Tech review
|
@heemin32 The first-pass draft is ready for your technical review. Please review for technical accuracy, gaps in information, and other technical-related information. You're welcome to schedule a meeting with me to talk through this content. Thanks! |
Signed-off-by: vagimeli <[email protected]>
heemin32
reviewed
May 23, 2023
heemin32
reviewed
May 23, 2023
Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
natebower
reviewed
Aug 23, 2023
|
|
||
| | Key | Description | Default | | ||
| |--------------------|-------------|---------| | ||
| | plugins.geospatial.ip2geo.datasource.endpoint | Default endpoint for creating the data source API. | Defaults to https://geoip.maps.opensearch.org/v1/geolite2-city/manifest.json. | |
There was a problem hiding this comment.
It looks like the terminating period shouldn't be part of the link.
_api-reference/ingest-apis/ip2geo.md
Outdated
| | `datasource` | Required | - | The data source name to use to look up geographical information. | | ||
| | `properties` | Optional | All fields in `datasource`. | The field that controls what properties are added to `target_field` from `datasource`. | | ||
| | `target_field` | Optional | ip2geo | The field that holds the geographical information looked up from the data source. | | ||
| | `ignore_missing` | Optional | false | If `true` and `field` does not exist, the processor quietly exits without modifying the document. | |
There was a problem hiding this comment.
The end of the description is a bit oddly worded. Do we just mean "the processor does not modify the document"?
There was a problem hiding this comment.
Revised to read: If set to true, the processor does not modify the document if the field does not exist or is null. Default is false.
_api-reference/ingest-apis/ip2geo.md
Outdated
| ``` | ||
| {% include copy-curl.html %} | ||
|
|
||
| **Step 2: Ingest a document into the index.** |
There was a problem hiding this comment.
"an index" instead of "the index"?
_api-reference/ingest-apis/ip2geo.md
Outdated
|
|
||
| **Step 2: Ingest a document into the index.** | ||
|
|
||
| The following query ingests a document into the index named `my-index`: |
There was a problem hiding this comment.
"an index" instead of "the index"?
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
vagimeli
added
6 - Done but waiting to merge
Signed-off-by: Melissa Vagi <[email protected]>
1 task
vagimeli
added
Closed - Duplicate or Cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new documentation about GeoIP automatic updating feature
Issues Resolved
#3524
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.