Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix menu cut off #315

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

gulderov
Copy link
Contributor

@gulderov gulderov commented Feb 26, 2024

Description

Menu height fix
image

Issues Resolved

[List any issues this PR will resolve]
fix #312

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gulderov gulderov force-pushed the reporting-menu-cut-off branch from 448066b to 8ef4d71 Compare February 26, 2024 11:23
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (a811806) to head (c84f7d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   71.05%   71.05%           
=======================================
  Files          31       31           
  Lines        2011     2011           
  Branches      430      430           
=======================================
  Hits         1429     1429           
  Misses        579      579           
  Partials        3        3           
Flag Coverage Δ
dashboards-report 71.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@joshuali925 joshuali925 merged commit e2fe9a0 into opensearch-project:main Mar 11, 2024
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Co-authored-by: Eric <[email protected]>
(cherry picked from commit e2fe9a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq pushed a commit that referenced this pull request Mar 11, 2024
(cherry picked from commit e2fe9a0)

Signed-off-by: Danila Gulderov <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] discover reporting tab: reporting menu cut off at bottom
3 participants