Revert jest tests config to use babel #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 57.42% 51.58% -5.84%
==========================================
Files 330 305 -25
Lines 12091 10644 -1447
Branches 2792 2790 -2
==========================================
- Hits 6943 5491 -1452
- Misses 5102 5107 +5
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
changed the title
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
joshuali925
approved these changes
Dec 21, 2023
| // Alternative to install them locally in node_modules | ||
| module.exports = function (api) { | ||
| // ensure env is test so that this config won't impact build or dev server | ||
| if (api.env('test')) { |
There was a problem hiding this comment.
i didn't check but is babel config not needed for either build or dev?
There was a problem hiding this comment.
This is likely used only in a testing environment (Jest) to ensure that the Babel configuration for tests is applied. I guess for bootstrap/build OSD scripts takes care of it.
kavithacm
approved these changes
Dec 21, 2023
YANG-DB
approved these changes
Dec 21, 2023
ps48
added a commit
that referenced
this pull request
Dec 21, 2023
* update jest config to use babel instead of ts-jest Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a262aaf) * remove ts-jest package Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 66d5621) * update yarn.lock file Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Dec 22, 2023
…ect#1319) (opensearch-project#1320) * update jest config to use babel instead of ts-jest Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a262aaf) * remove ts-jest package Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 66d5621) * update yarn.lock file Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ect#1319) (opensearch-project#1320) * update jest config to use babel instead of ts-jest Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a262aaf) * remove ts-jest package Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 66d5621) * update yarn.lock file Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 2c969e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert to jest tests to using babel. This PR aligns with the long term solution mentioned in the below issue.
This PR removes ts-jest dependency and aligns with all other dashboards plugins to use babel for transform.
NOTE: Some jest tests or integrations were failing after the migration. Ideally should have been caught by ts-jest earlier. cc: @Swiddis
Issues Resolved
#1306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.