Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change variables naming under context of Agent Framework #97

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jan 11, 2024

Description

  1. Change variable names from sessionId to conversationId.
  2. Change file names from session-related to conversation-related.

Issues Resolved

#96

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e278a47) 93.14% compared to head (69c7a47) 95.29%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   93.14%   95.29%   +2.15%     
==========================================
  Files          46       46              
  Lines        1255     1255              
  Branches      298      300       +2     
==========================================
+ Hits         1169     1196      +27     
+ Misses         84       57      -27     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member Author

SuZhou-Joe commented Jan 11, 2024

Did a regression test on:

  • Ask Chatbot and get response
  • Loading conversations and conversation
  • Showing how was it generated
  • Change conversation title
  • Delete conversation
  • Search conversation
  • Regenerate interaction
  • Give feedback on interaction
  • Save to Notebook
  • Render data grid

server/routes/get_session.test.ts Outdated Show resolved Hide resolved
public/hooks/__tests__/use_sessions.test.ts Outdated Show resolved Hide resolved
server/routes/get_sessions.test.ts Outdated Show resolved Hide resolved
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 43332a9 into opensearch-project:main Jan 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants