-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: some optimization for customized render function #94
Merged
SuZhou-Joe
merged 12 commits into
opensearch-project:main
from
SuZhou-Joe:feature/data-grid
Jan 11, 2024
Merged
feat: some optimization for customized render function #94
SuZhou-Joe
merged 12 commits into
opensearch-project:main
from
SuZhou-Joe:feature/data-grid
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 93.14% 95.29% +2.14%
==========================================
Files 46 46
Lines 1255 1253 -2
Branches 298 297 -1
==========================================
+ Hits 1169 1194 +25
+ Misses 84 57 -27
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/data-grid
branch
from
January 10, 2024 09:05
70c3ab7
to
718fc3f
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
January 10, 2024 09:11
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
reviewed
Jan 10, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
joshuali925
reviewed
Jan 10, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#95
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.