Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ppl data grid type in save to notebook function #93

Merged

Conversation

raintygao
Copy link
Collaborator

Description

support ppl data grid type in save to notebook function

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: tygao <[email protected]>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (510b685) 93.26% compared to head (9ace4d9) 93.14%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   93.26%   93.14%   -0.13%     
==========================================
  Files          46       46              
  Lines        1218     1255      +37     
  Branches      291      298       +7     
==========================================
+ Hits         1136     1169      +33     
- Misses         80       84       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam
Copy link
Collaborator

wanglam commented Jan 8, 2024

@raintygao Since we added a new content type 'ppl_data_grid', shall we add this content type support in the message content?

@raintygao
Copy link
Collaborator Author

@raintygao Since we added a new content type 'ppl_data_grid', shall we add this content type support in the message content?

Yes, @SuZhou-Joe will work on that.

@raintygao raintygao merged commit e278a47 into opensearch-project:main Jan 8, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants