Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass real error info from backend #92

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jan 4, 2024

Description

Bypass error from _execute API to better debug and find root cause.

Before:

image

After:

image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe changed the title feat: throw error from backend fix: bypass real error info from backend Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4290b0) 93.45% compared to head (7430e1e) 93.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   93.45%   93.44%   -0.02%     
==========================================
  Files          46       46              
  Lines        1253     1251       -2     
  Branches      299      297       -2     
==========================================
- Hits         1171     1169       -2     
  Misses         80       80              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe added enhancement New feature or request Skip-Changelog labels Jan 5, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
Copy link
Member Author

image In my local env it is 100% and I guess it is because I delete some of covered lines and reduce the total coverage percentage.

@SuZhou-Joe SuZhou-Joe merged commit 4c0386b into opensearch-project:main Jan 5, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Skip-Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants