-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search root agent id by rootAgentName specified in opensearch_dashboards.yml #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds.yml Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
Hailong-am,
wanglam and
raintygao
as code owners
December 27, 2023 03:01
SuZhou-Joe
reviewed
Dec 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 93.26% 93.44% +0.17%
==========================================
Files 46 46
Lines 1218 1251 +33
Branches 291 298 +7
==========================================
+ Hits 1136 1169 +33
Misses 80 80
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: gaobinlong <[email protected]>
SuZhou-Joe
reviewed
Dec 27, 2023
wanglam
reviewed
Dec 27, 2023
Signed-off-by: gaobinlong <[email protected]>
wanglam
approved these changes
Dec 28, 2023
raintygao
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to change the behavior of getting root agent id, users have to specify the name of the root agent in the yml, and when they send the first message in the chat box, the node server will call the search agent api in ml-commons to get the root agent id, if multiple root agents are found, we only fetch the latest one.
This PR also lets users to change the root agent dynamically, they can delete the old root agent firstly and create a new one with the old name, when sending message, the api in backend will throw 404 error with message
resource_not_found_exception
, this time the node server will retry to search the root agent by the specified name, if found, the new root agent id will be used and cached.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.