Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync new commits from agent framework to main #71

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Dec 13, 2023

Description

#66 is merged but there are some new commits added to agent framework in the process. Adding another PR to sync them. Since conflicts were resolved, we can directly rebase agent framework on main branch to sync the new commits

Please rebase this PR, do not squash

Issues Resolved

partially #72

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

wanglam and others added 6 commits December 13, 2023 14:26
* test: add unit test for chst history page

Signed-off-by: Lin Wang <[email protected]>

* test: add unit tests for chat history list

Signed-off-by: Lin Wang <[email protected]>

* test: add unit tests for chat history search list

Signed-off-by: Lin Wang <[email protected]>

* test: remove unnecessary act

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
* test: add test for saving to notebook

Signed-off-by: tygao <[email protected]>

* update

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
* test: add unit tests for chat window header

Signed-off-by: Lin Wang <[email protected]>

* test: add ut for chat window header title

Signed-off-by: Lin Wang <[email protected]>

* test: add unit tests for chat experimental badge

Signed-off-by: Lin Wang <[email protected]>

* Address PR comments

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
* feat: more robust parser to get suggested actions

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code and optimize performance

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
@wanglam
Copy link
Collaborator

wanglam commented Dec 14, 2023

@joshuali925 The linkchecker was failed. Shall we fix this task before merge?

@ruanyl ruanyl merged commit 7695943 into main Dec 14, 2023
15 of 27 checks passed
@joshuali925
Copy link
Member Author

@joshuali925 The linkchecker was failed. Shall we fix this task before merge?

sure, could you review #73. it's not part of the agent-framework commits so i didn't want to include it here

@SuZhou-Joe SuZhou-Joe deleted the feature/agent-framework branch January 2, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants