-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync new commits from agent framework to main #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add unit test for chst history page Signed-off-by: Lin Wang <[email protected]> * test: add unit tests for chat history list Signed-off-by: Lin Wang <[email protected]> * test: add unit tests for chat history search list Signed-off-by: Lin Wang <[email protected]> * test: remove unnecessary act Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
* test: add test for saving to notebook Signed-off-by: tygao <[email protected]> * update Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]>
* test: add unit tests for chat window header Signed-off-by: Lin Wang <[email protected]> * test: add ut for chat window header title Signed-off-by: Lin Wang <[email protected]> * test: add unit tests for chat experimental badge Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]>
* feat: more robust parser to get suggested actions Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code and optimize performance Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
--------- Signed-off-by: Yulong Ruan <[email protected]>
joshuali925
requested review from
lezzago,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
December 13, 2023 21:14
8 tasks
ruanyl
approved these changes
Dec 14, 2023
raintygao
approved these changes
Dec 14, 2023
@joshuali925 The |
sure, could you review #73. it's not part of the agent-framework commits so i didn't want to include it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#66 is merged but there are some new commits added to agent framework in the process. Adding another PR to sync them. Since conflicts were resolved, we can directly rebase agent framework on main branch to sync the new commits
Please rebase this PR, do not squash
Issues Resolved
partially #72
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.