add unit test for useChatActions hook #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 74.29% 82.12% +7.83%
==========================================
Files 43 43
Lines 1023 1024 +1
Branches 245 238 -7
==========================================
+ Hits 760 841 +81
+ Misses 261 182 -79
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Dec 13, 2023
| ); | ||
| }); | ||
|
|
||
| it('should handle regenerate error', async () => { |
There was a problem hiding this comment.
Shall we add test case for regenerate abort?
ruanyl
requested review from
lezzago,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
raintygao
as code owners
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
unit-test-use-chat-actions-hook
branch
from
027a7d9 to
a5eac23
Compare
Signed-off-by: Yulong Ruan <[email protected]>
wanglam
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.