[DO NOT MERGE] diffs above agent framework #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
…ct#31) Signed-off-by: Ashish Agrawal <[email protected]>
* feat: add maintainers Signed-off-by: SuZhou-Joe <[email protected]> * feat: format Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #67 +/- ##
========================================================
Coverage 58.67% 58.67%
========================================================
Files 46 46
Lines 1089 1089
Branches 252 252
========================================================
Hits 639 639
Misses 441 441
Partials 9 9 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
commented
Dec 13, 2023
SuZhou-Joe
commented
Dec 13, 2023
Comment on lines
+30
to
+37
| "persistent" : { | ||
| "plugins.ml_commons.trusted_connector_endpoints_regex": | ||
| [ "^https://runtime\\.sagemaker\\..*[a-z0-9-]\\.amazonaws\\.com/.*$", | ||
| "^https://api\\.openai\\.com/.*$", | ||
| "^https://api\\.cohere\\.ai/.*$", | ||
| "^https://bedrock-runtime\\.us-east-1\\.amazonaws\\.com/.*$" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Seems to break link checker. Perhaps we need to remove link checker.
There was a problem hiding this comment.
good point, we can exclude links with ^https which is probably regex. i'll send a separate PR since it's not part of the merge
8 tasks
|
closing since #66 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.