test: add unit test for save to notebook feature #62
Conversation
Signed-off-by: tygao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #62 +/- ##
============================================================
+ Coverage 48.75% 65.28% +16.52%
============================================================
Files 46 41 -5
Lines 1087 965 -122
Branches 250 231 -19
============================================================
+ Hits 530 630 +100
+ Misses 548 331 -217
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
| ), | ||
| }); | ||
| } catch (error) { | ||
| if (error.message === 'Not Found') { |
There was a problem hiding this comment.
This may out of the scope of this PR, but I'm wondering if it's ok to assume observability plugin is not installed when error message is Not Found? Because Not Found sounds like a general error message.
There was a problem hiding this comment.
I think we can assume they are same at this time because observability will register this route automatically if it is installed. OSD server will throw Not Found error if this route is not registered. I tried to import an error constant from OSD to avoid directly judge this string, but OSD doesn't export.
Signed-off-by: tygao <[email protected]>
raintygao
merged commit 1670183
into
opensearch-project:feature/agent-framework
* test: add test for saving to notebook Signed-off-by: tygao <[email protected]> * update Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]>
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.