Fix back button disappear on trace page #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #59 +/- ##
===========================================================
- Coverage 48.75% 48.71% -0.05%
===========================================================
Files 46 46
Lines 1087 1088 +1
Branches 250 251 +1
===========================================================
Hits 530 530
- Misses 548 549 +1
Partials 9 9 ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Dec 11, 2023
public/chat_header_button.tsx
Outdated
| @@ -65,7 +65,9 @@ export const HeaderChatButton: React.FC<HeaderChatButtonProps> = (props) => { | |||
| selectedTabId, | |||
| preSelectedTabId, | |||
| setSelectedTabId: (tabId: TabId) => { | |||
| setPreSelectedTabId(selectedTabId); | |||
| if (selectedTabId !== tabId) { | |||
There was a problem hiding this comment.
How about add this a selectedTabId === "chat" check to use_chat_actions? Then, we don't need to call setSelectedTabId if selectedTabId is already "trace".
There was a problem hiding this comment.
sounds like a better place to add this special logic for trace, will move it to file use_chat_actions.tsx
Signed-off-by: Hailong Cui <[email protected]>
wanglam
approved these changes
Dec 11, 2023
SuZhou-Joe
approved these changes
Dec 11, 2023
Hailong-am
merged commit 47a8cc0
into
opensearch-project:feature/agent-framework
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When click how was it generated twice, back button will disappear. Fix it by set chat window pre state when it changed.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.