Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mocks and unit test for router.ts #57

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Dec 11, 2023

Description

  1. Add unit test for routes.ts
  2. Add mocks for StorageService and ChatService.
  3. Optimize error handling in send_message router.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36ac34b) 23.28% compared to head (55e831c) 36.61%.
Report is 4 commits behind head on feature/agent-framework.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/agent-framework      #57       +/-   ##
============================================================
+ Coverage                    23.28%   36.61%   +13.32%     
============================================================
  Files                           42       46        +4     
  Lines                          919     1087      +168     
  Branches                       227      250       +23     
============================================================
+ Hits                           214      398      +184     
+ Misses                         698      681       -17     
- Partials                         7        8        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 45ee7fd into opensearch-project:feature/agent-framework Dec 11, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant