Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for CoreVisualization and ChatFlyout #56

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 8, 2023

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c70bcfc) 48.75% compared to head (08596ec) 53.44%.
Report is 1 commits behind head on feature/agent-framework.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/agent-framework      #56      +/-   ##
===========================================================
+ Coverage                    48.75%   53.44%   +4.68%     
===========================================================
  Files                           46       46              
  Lines                         1087     1089       +2     
  Branches                       250      251       +1     
===========================================================
+ Hits                           530      582      +52     
+ Misses                         548      498      -50     
  Partials                         9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl force-pushed the unit-test-core-vis-and-chat-flyout branch from 6382069 to 08596ec Compare December 12, 2023 02:54
@ruanyl ruanyl merged commit 3ff4134 into opensearch-project:feature/agent-framework Dec 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants