Add tests for ChatPageContent component #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add MessageBubble unit tests add MessageContent unit tests remove MessageFooter which is not needed anymore Signed-off-by: Yulong Ruan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #54 +/- ##
============================================================
+ Coverage 27.40% 39.33% +11.93%
============================================================
Files 40 40
Lines 905 905
Branches 223 223
============================================================
+ Hits 248 356 +108
+ Misses 650 541 -109
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Dec 8, 2023
wanglam
approved these changes
Dec 8, 2023
Signed-off-by: Yulong Ruan <[email protected]>
joshuali925
approved these changes
Dec 8, 2023
|
|
||
| jest.mock('./messages/message_content', () => { | ||
| return { MessageContent: () => <div /> }; | ||
| }); |
There was a problem hiding this comment.
just curious why are child components mocked?
There was a problem hiding this comment.
That's a good question! There has been lots of discussions around this. For unit test, I tend to mock child components in RTL which are smart components, for example, the components that:
- Access data via API call
- Have side effects such as read/write local storage
- Access context
- Access global state
By mocking such components, I think it makes the tests concise and less fragile. And ofc, the child component should be covered by its own unit tests.
SuZhou-Joe
approved these changes
Dec 11, 2023
ruanyl
merged commit 3d46971
into
opensearch-project:feature/agent-framework
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add MessageBubble unit tests
add MessageContent unit tests
remove MessageFooter which is not needed anymore
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.