Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for ChatPage and ChatInputControls #45

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Dec 5, 2023

removed ChatPageGreetings which is not need anymore

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruanyl ruanyl requested a review from wanglam December 5, 2023 08:24
@ruanyl ruanyl force-pushed the test-for-chat-page-chat-inputs branch from a7c96e5 to 46e7b23 Compare December 5, 2023 08:25
removed ChatPageGreetings which is not need anymore

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl force-pushed the test-for-chat-page-chat-inputs branch from 6bd36e0 to 4d675a1 Compare December 6, 2023 03:12
@ruanyl ruanyl requested a review from SuZhou-Joe December 6, 2023 03:12
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3be4f51) 22.86% compared to head (4d675a1) 27.10%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/agent-framework      #45      +/-   ##
===========================================================
+ Coverage                    22.86%   27.10%   +4.23%     
===========================================================
  Files                           42       40       -2     
  Lines                          892      878      -14     
  Branches                       221      217       -4     
===========================================================
+ Hits                           204      238      +34     
+ Misses                         681      633      -48     
  Partials                         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 9663fb1 into opensearch-project:feature/agent-framework Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants