display feedback state when loading a past conversation #41
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #41 +/- ##
===========================================================
+ Coverage 22.86% 23.28% +0.41%
===========================================================
Files 42 42
Lines 892 919 +27
Branches 221 227 +6
===========================================================
+ Hits 204 214 +10
- Misses 681 698 +17
Partials 7 7 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
force-pushed
the
feature/agent-framework
branch
from
b9360e2 to
4ff6726
Compare
raintygao
force-pushed
the
feat-display-feedback
branch
from
633859d to
ec5fa8f
Compare
Signed-off-by: tygao <[email protected]>
SuZhou-Joe
force-pushed
the
feat-display-feedback
branch
from
ec5fa8f to
453a193
Compare
| @@ -12,7 +12,7 @@ export interface Interaction { | |||
| conversation_id: string; | |||
| interaction_id: string; | |||
| create_time: string; | |||
| additional_info?: Record<string, unknown>; | |||
There was a problem hiding this comment.
The Interaciton type is used in many places. The key-value pair does not have to be Record<string, boolean> I suppose?
There was a problem hiding this comment.
Yes, it may can also be string. But i assumed this could be updated when needed in future or predefined.
There was a problem hiding this comment.
What about { feedback?: SendFeedbackBody, [key: string]: unknown }.
My intent to set value as unknown is letting consumers to cast to other types explicitly in their functions if they want to consume specific field and know exactly what the type those values are.
https://github.com/opensearch-project/dashboards-assistant/blob/feature/agent-framework/server/parsers/visualization_card_parser.ts#L19 for reference.
There was a problem hiding this comment.
That makes sense.
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
raintygao
merged commit 36ac34b
into
opensearch-project:feature/agent-framework
Description
display feedback state when loading a past conversation
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.