Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve alert summary with backend log pattern experience #389

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Improve alert summary with backend log pattern experience #389

merged 3 commits into from
Jan 9, 2025

Conversation

songkant-aws
Copy link
Contributor

@songkant-aws songkant-aws commented Jan 9, 2025 •
edited
Loading

Description

This PR does two changes

  1. Adjust alert summary with log pattern API trigger condition(to not rely on frontend passed log pattern)
  2. Catch AgentNotFoundError correctly while detecting insight agentId

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@songkant-aws
Add change log
2ffe32c 
Signed-off-by: Songkan Tang <[email protected]>
ruanyl
ruanyl approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@xluo-aws xluo-aws merged commit 7858c95 into opensearch-project:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@gaobinlong gaobinlong Awaiting requested review from gaobinlong gaobinlong is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songkant-aws @ruanyl @SuZhou-Joe @xluo-aws