Optimize the response of AI agent APIs #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
Hailong-am,
wanglam and
raintygao
as code owners
gaobinlong
changed the title
gaobinlong
changed the title
Signed-off-by: gaobinlong <[email protected]>
|
@ruanyl @SuZhou-Joe @Hailong-am @xluo-aws please help to review this PR, thanks! |
Hailong-am
approved these changes
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
xluo-aws
reviewed
Dec 2, 2024
xluo-aws
reviewed
Dec 2, 2024
Signed-off-by: gaobinlong <[email protected]>
xluo-aws
approved these changes
Dec 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Optimize the response of executing AI agents Signed-off-by: gaobinlong <[email protected]> * Add change log Signed-off-by: gaobinlong <[email protected]> * Optimize the code Signed-off-by: gaobinlong <[email protected]> * Optimize the response Signed-off-by: gaobinlong <[email protected]> * Optimize the code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 581a7ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
gaobinlong
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Optimize the response of executing AI agents Signed-off-by: gaobinlong <[email protected]> * Add change log Signed-off-by: gaobinlong <[email protected]> * Optimize the code Signed-off-by: gaobinlong <[email protected]> * Optimize the response Signed-off-by: gaobinlong <[email protected]> * Optimize the code Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 581a7ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling the APIs like api/assistant/summary, api/assistant/insight and other related APIs, if OpenSearch cluster returns 4xx error, we just return 500 error or 400 error directly, which is not elegant, we should optimize this by checking the status code, if it's 4xx error, we return the original response, and if it's 5xx error, return an general error message.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.