Fix redirect new session when dock right #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
…tConversationModalClose Signed-off-by: Lin Wang <[email protected]>
Example of using index.ts and importing one line instead of two. Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
reviewed
Dec 1, 2023
| @@ -6,12 +6,11 @@ | |||
| import { EuiFlyoutBody, EuiFlyoutFooter, EuiPage, EuiPageBody, EuiSpacer } from '@elastic/eui'; | |||
| import React, { useCallback, useState } from 'react'; | |||
| import cs from 'classnames'; | |||
| import { useChatContext } from '../../contexts/chat_context'; | |||
| import { useChatState } from '../../hooks/use_chat_state'; | |||
| import { useObservable } from 'react-use'; | |||
There was a problem hiding this comment.
I am a little bit concerned about this shadow dependency. The react-use is coming from OSD. Should we declare the dependency of react-use in the package.json of dashboards-assistant? @joshuali925 @kavilla
SuZhou-Joe
approved these changes
Dec 1, 2023
ruanyl
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #26
Fix jump to new chat page after current session deleted in dock right mode like below video:
Screen.Recording.2023-11-29.at.14.41.57.mov
It should stay the same page
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.