refactor: Update alerting DSL verify mechanism #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
| @@ -55,10 +56,19 @@ export const GeneratePopoverBody: React.FC<{ | |||
| const getMonitorType = async () => { | |||
| const context = await incontextInsight.contextProvider?.(); | |||
There was a problem hiding this comment.
Not related to this PR, could you store this context in a variable so we don't need to invoke this provider multiple times?(It got 3 invoking for now.) contextProvider for alerting is a heavy operation, it will execute a dsl and a ppl each time.
There was a problem hiding this comment.
Sure, let me see how to redesign this and do it in a separate PR in order not to have any influence on upcoming release.
Hailong-am
approved these changes
Oct 25, 2024
public/utils/alerting.ts
Outdated
Comment on lines
152
to
158
| export const validateToTimeRange = (time: string) => { | ||
| // Alerting uses this format in to field of time range filter. | ||
| const TO_TIME_FORMAT = 'YYYY-MM-DDTHH:mm:ssZ'; | ||
| return moment.utc(time, TO_TIME_FORMAT, true).isValid(); | ||
| }; | ||
|
|
||
| export const extractTimeRangeDSL = (filters: NestedRecord[]) => { |
There was a problem hiding this comment.
could we add a unit test for these two functions?
| setDisplayDiscoverButton(shoudDisplayDiscoverButton); | ||
| let hasTimeRangeFilter = false; | ||
| if (dsl) { | ||
| const dslObject = JSON.parse(dsl); |
There was a problem hiding this comment.
add try catch for JSON.parse?
Signed-off-by: tygao <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
(cherry picked from commit 0f4e48a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Oct 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
(cherry picked from commit 0f4e48a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.