Hide incompatible index patterns #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Kapian1234
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
ruanyl
reviewed
Oct 17, 2024
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| import React, { useCallback, useMemo, useState, useEffect, useRef } from 'react'; | |||
| import { i18n } from '@osd/i18n'; | |||
|
|
|||
| import { EuiComboBoxOptionOption } from '@elastic/eui'; | |||
There was a problem hiding this comment.
This new import seems is not used?
There was a problem hiding this comment.
yes I'll delete it
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
ruanyl
reviewed
Oct 17, 2024
CHANGELOG.md
Outdated
| - feat: expose a general function for agent execution([268](https://github.com/opensearch-project/dashboards-assistant/pull/268)) | ||
| - Fix CVE-2024-4067 ([#269](https://github.com/opensearch-project/dashboards-assistant/pull/269)) | ||
| - feat: add a dashboards-assistant trigger in query editor([265](https://github.com/opensearch-project/dashboards-assistant/pull/265)) | ||
| - fix: make sure $schema always added to LLM generated vega json object([#252](https://github.com/opensearch-project/dashboards-assistant/pull/252)) | ||
| - fix: make sure \$schema always added to LLM generated vega json object([#252](https://github.com/opensearch-project/dashboards-assistant/pull/252)) |
CHANGELOG.md
Outdated
| @@ -52,3 +52,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Refactor popover to add message action bar and add metrics to thumb-up and thumb-down([#304](https://github.com/opensearch-project/dashboards-assistant/pull/304)) | |||
| - Support log pattern analysis ([#339](https://github.com/opensearch-project/dashboards-assistant/pull/339)) | |||
| - Pass top N log pattern data from alerting to agent ([#341] (https://github.com/opensearch-project/dashboards-assistant/pull/341)) | |||
| - Hide incompatible index patterns ([#354] (https://github.com/opensearch-project/dashboards-assistant/pull/354)) | |||
Hailong-am
reviewed
Oct 17, 2024
| label: 'Index patterns', | ||
| options: [ | ||
| { | ||
| label: 'No supported index patterns', |
There was a problem hiding this comment.
sorry I forgot it
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Jincheng Wan <[email protected]>
ruanyl
approved these changes
Oct 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Display a message when there is no supported data source Signed-off-by: Kapian1234 <[email protected]> * filter out incompatible index patterns Signed-off-by: Kapian1234 <[email protected]> * Display a message when there is no supported data source Signed-off-by: Kapian1234 <[email protected]> * remove log Signed-off-by: Kapian1234 <[email protected]> * remove unused import Signed-off-by: Kapian1234 <[email protected]> * add changelog Signed-off-by: Kapian1234 <[email protected]> * modify changelog Signed-off-by: Kapian1234 <[email protected]> * resolve some issues Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> (cherry picked from commit e3ec245) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Display a message when there is no supported data source Signed-off-by: Kapian1234 <[email protected]> * filter out incompatible index patterns Signed-off-by: Kapian1234 <[email protected]> * Display a message when there is no supported data source Signed-off-by: Kapian1234 <[email protected]> * remove log Signed-off-by: Kapian1234 <[email protected]> * remove unused import Signed-off-by: Kapian1234 <[email protected]> * add changelog Signed-off-by: Kapian1234 <[email protected]> * modify changelog Signed-off-by: Kapian1234 <[email protected]> * resolve some issues Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> (cherry picked from commit e3ec245) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before:
after:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.