Edit viz in a dialog #351
Merged
Edit viz in a dialog #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
ruanyl
force-pushed
the
edit-viz-in-a-dialog
branch
from
b4d0727 to
4a5f7ef
Compare
Hailong-am
reviewed
Oct 17, 2024
Hailong-am
approved these changes
Oct 21, 2024
Comment on lines
+181
to
+182
| setInputQuestion(JSON.parse(savedVis.uiState ?? '{}').input ?? ''); | ||
| setCurrentInstruction(JSON.parse(savedVis.uiState ?? '{}').instruction ?? ''); |
There was a problem hiding this comment.
do we need to add try catch here in case uiState is invalid json?
There was a problem hiding this comment.
The exception should be handled by the .catch
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
edit-viz-in-a-dialog
branch
from
805cbce to
8d01967
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
* feat: supporting edit visualization with input from a dialog Signed-off-by: Yulong Ruan <[email protected]> * fix: save instruction input Signed-off-by: Yulong Ruan <[email protected]> * fix: change internal error to bad request Signed-off-by: Yulong Ruan <[email protected]> * fix: use sass variable for 12px font size Signed-off-by: Yulong Ruan <[email protected]> * add CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 6a49d78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Oct 22, 2024
* feat: supporting edit visualization with input from a dialog Signed-off-by: Yulong Ruan <[email protected]> * fix: save instruction input Signed-off-by: Yulong Ruan <[email protected]> * fix: change internal error to bad request Signed-off-by: Yulong Ruan <[email protected]> * fix: use sass variable for 12px font size Signed-off-by: Yulong Ruan <[email protected]> * add CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 6a49d78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Screen.Recording.2024-10-16.at.18.02.45.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.