feat: take index pattern and user input to t2viz from discover #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
gaobinlong
reviewed
Oct 16, 2024
Hailong-am
approved these changes
Oct 16, 2024
Comment on lines
+346
to
+352
| const queryAssistInputEle = document.getElementsByClassName('queryAssist__input')[0]; | ||
| if (queryAssistInputEle instanceof HTMLInputElement) { | ||
| const input = queryAssistInputEle.value; | ||
| if (input) { | ||
| url.searchParams.set(ASSISTANT_INPUT_URL_SEARCH_KEY, input); | ||
| } | ||
| } |
There was a problem hiding this comment.
can we get the value from the place triggered this action? If so, we can use context to pass the value.
There was a problem hiding this comment.
It's a bit tricky, the context menu is updated based on data.query.queryString.getUpdates$(), but the query assistant input is not part of it. Didn't find a way to easily update the context when the input changes. I have a todo to refactor this when we moved query assistant to dashboards-assistant plugin.
gaobinlong
approved these changes
Oct 16, 2024
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
* feat: take index pattern and user input to t2viz from discover Signed-off-by: Yulong Ruan <[email protected]> * import data set type INDEX_PATTERN from data plugin Signed-off-by: Yulong Ruan <[email protected]> * chore: update CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 98bf315) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Oct 17, 2024
…#353) * feat: take index pattern and user input to t2viz from discover Signed-off-by: Yulong Ruan <[email protected]> * import data set type INDEX_PATTERN from data plugin Signed-off-by: Yulong Ruan <[email protected]> * chore: update CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 98bf315) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Screen.Recording.2024-10-15.at.13.34.35.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.