Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix(t2viz): string escape should only escape field #326

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[Backport 2.x] fix(t2viz): string escape should only escape field #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion public/components/visualization/text2vega.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ export class Text2Vega {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const escapeField = (json: any, field: string) => {
if (json[field]) {
if (typeof json[field] === 'string') {
// Only escape field which name is 'field'
if (typeof json[field] === 'string' && field === 'field') {
json[field] = json[field].replace(/\./g, '\\.');
}
if (typeof json[field] === 'object') {
Expand All @@ -132,6 +133,7 @@ export class Text2Vega {

// need to escape field: geo.city -> field: geo\\.city
escapeField(res, 'encoding');
escapeField(res, 'layer');
return res;
}

Expand Down
Loading