Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ws from 8.16.0 to 8.18.0 #221

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 23, 2024

Bumps ws from 8.16.0 to 8.18.0.

Release notes

Sourced from ws's releases.

8.18.0

Features

  • Added support for Blob (#2229).

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

... (truncated)

Commits
  • 976c53c [dist] 8.18.0
  • 59b9629 [feature] Add support for Blob (#2229)
  • 0d1b5e6 [security] Use more descriptive text for 2017 vulnerability link
  • 15f11a0 [security] Add new DoS vulnerability to SECURITY.md
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.18.0.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.16.0...8.18.0)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.18.0 branch from 9244cab to 3a0b3f8 Compare July 24, 2024 03:12
@xluo-aws xluo-aws merged commit beac8cc into main Jul 24, 2024
14 of 17 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ws-8.18.0 branch July 24, 2024 08:16
@Hailong-am Hailong-am added backport 2.x Trigger the backport flow to 2.x backport 2.16 labels Jul 27, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.x
# Create a new branch
git switch --create backport/backport-221-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 beac8cce7e4e69ca945ed249965ff8e25d6d4859
# Push it to GitHub
git push --set-upstream origin backport/backport-221-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-221-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.16
# Create a new branch
git switch --create backport/backport-221-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 beac8cce7e4e69ca945ed249965ff8e25d6d4859
# Push it to GitHub
git push --set-upstream origin backport/backport-221-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-221-to-2.16.

Hailong-am pushed a commit to Hailong-am/dashboards-assistant that referenced this pull request Jul 27, 2024
…endabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Hailong-am pushed a commit to Hailong-am/dashboards-assistant that referenced this pull request Jul 27, 2024
…endabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Signed-off-by: Cui Hailong <[email protected]>
Hailong-am pushed a commit to Hailong-am/dashboards-assistant that referenced this pull request Jul 27, 2024
…endabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Hailong-am pushed a commit to Hailong-am/dashboards-assistant that referenced this pull request Jul 27, 2024
…endabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Signed-off-by: Cui Hailong <[email protected]>
Hailong-am pushed a commit to Hailong-am/dashboards-assistant that referenced this pull request Jul 27, 2024
…endabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Signed-off-by: Cui Hailong <[email protected]>
Hailong-am added a commit that referenced this pull request Jul 29, 2024
… 8.18.0 (#244)

* Merge pull request #221 from opensearch-project/dependabot/npm_and_yarn/ws-8.18.0

build(deps): bump ws from 8.16.0 to 8.18.0

(cherry picked from commit beac8cc)
Signed-off-by: Cui Hailong <[email protected]>

* changelog

Signed-off-by: Cui Hailong <[email protected]>

---------

Signed-off-by: Cui Hailong <[email protected]>
Co-authored-by: Xuesong Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x backport 2.16 failed backport Mend: dependency security vulnerability Security vulnerability detected by Mend v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants