Initial implementation of context aware alert analysis #215

songkant-aws · 2024-07-12T06:38:50Z

Description

Initial context aware alert analysis implementation in assistant dashboard by leveraging existing IncontextInsight 'GeneratePopover' component

Issues Resolved

[Issue #214 ]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test.
New functionality has user manual doc added.
Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <[email protected]>

…rate summary Signed-off-by: Songkan Tang <[email protected]>

Signed-off-by: Songkan Tang <[email protected]>

wanglam · 2024-07-12T08:39:34Z

@songkant-aws Is this PR target for 2.16?

common/types/chat_saved_object_attributes.ts

server/services/chat/olly_chat_service.ts

server/routes/chat_routes.ts

public/components/incontext_insight/index.tsx

Signed-off-by: Songkan Tang <[email protected]>

songkant-aws · 2024-07-16T06:54:04Z

@songkant-aws Is this PR target for 2.16?

Yes, the PR is targeting for 2.16 @wanglam

public/components/incontext_insight/generate_popover_body.tsx

server/services/chat/olly_chat_service.ts

Signed-off-by: Songkan Tang <[email protected]>

public/components/incontext_insight/generate_popover_body.tsx

Signed-off-by: Songkan Tang <[email protected]>

…contextInsight Signed-off-by: Songkan Tang <[email protected]>

Signed-off-by: Songkan Tang <[email protected]>

wanglam

Great work! LGTM!

Hailong-am

seems there has a conflict for changelog file

Signed-off-by: Songkan Tang <[email protected]>

songkant-aws · 2024-07-24T08:57:23Z

seems there has a conflict for changelog file

Resolved changelog conflict

raintygao · 2024-07-24T09:03:58Z

seems there has a conflict for changelog file

Resolved changelog conflict

@songkant-aws Should this PR be merged in 2.16? If so, I suppose we should add a label and update release notes.

songkant-aws · 2024-07-24T09:18:54Z

@raintygao As far as I know, it's not required to be merged in 2.16.

Signed-off-by: Songkan Tang <[email protected]>

* support context aware alert analysis Signed-off-by: Hailong Cui <[email protected]> * Render GeneratePopover IncontextInsight component as a button to generate summary Signed-off-by: Songkan Tang <[email protected]> * Remove hardcoded assistant role from the parameter payload Signed-off-by: Songkan Tang <[email protected]> * Make GeneratePopoverBody as independent component Signed-off-by: Songkan Tang <[email protected]> * Update change log Signed-off-by: Songkan Tang <[email protected]> * Add independent GeneratePopoverBody ut and reorgnize constants Signed-off-by: Songkan Tang <[email protected]> * Simplify states of loading to get summary process Signed-off-by: Songkan Tang <[email protected]> * Make IncontextInsight not shareable and each component has its own IncontextInsight Signed-off-by: Songkan Tang <[email protected]> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 32888dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

* support context aware alert analysis Signed-off-by: Hailong Cui <[email protected]> * Render GeneratePopover IncontextInsight component as a button to generate summary Signed-off-by: Songkan Tang <[email protected]> * Remove hardcoded assistant role from the parameter payload Signed-off-by: Songkan Tang <[email protected]> * Make GeneratePopoverBody as independent component Signed-off-by: Songkan Tang <[email protected]> * Update change log Signed-off-by: Songkan Tang <[email protected]> * Add independent GeneratePopoverBody ut and reorgnize constants Signed-off-by: Songkan Tang <[email protected]> * Simplify states of loading to get summary process Signed-off-by: Songkan Tang <[email protected]> * Make IncontextInsight not shareable and each component has its own IncontextInsight Signed-off-by: Songkan Tang <[email protected]> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 32888dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…oject#215) (opensearch-project#271) * support context aware alert analysis Signed-off-by: Hailong Cui <[email protected]> * Render GeneratePopover IncontextInsight component as a button to generate summary Signed-off-by: Songkan Tang <[email protected]> * Remove hardcoded assistant role from the parameter payload Signed-off-by: Songkan Tang <[email protected]> * Make GeneratePopoverBody as independent component Signed-off-by: Songkan Tang <[email protected]> * Update change log Signed-off-by: Songkan Tang <[email protected]> * Add independent GeneratePopoverBody ut and reorgnize constants Signed-off-by: Songkan Tang <[email protected]> * Simplify states of loading to get summary process Signed-off-by: Songkan Tang <[email protected]> * Make IncontextInsight not shareable and each component has its own IncontextInsight Signed-off-by: Songkan Tang <[email protected]> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 32888dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…279) * support context aware alert analysis * Render GeneratePopover IncontextInsight component as a button to generate summary * Remove hardcoded assistant role from the parameter payload * Make GeneratePopoverBody as independent component * Update change log * Add independent GeneratePopoverBody ut and reorgnize constants * Simplify states of loading to get summary process * Make IncontextInsight not shareable and each component has its own IncontextInsight * Enable context aware alert only if feature flag is enabled --------- (cherry picked from commit 32888dd) Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: Songkan Tang <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…oject#215) * support context aware alert analysis Signed-off-by: Hailong Cui <[email protected]> * Render GeneratePopover IncontextInsight component as a button to generate summary Signed-off-by: Songkan Tang <[email protected]> * Remove hardcoded assistant role from the parameter payload Signed-off-by: Songkan Tang <[email protected]> * Make GeneratePopoverBody as independent component Signed-off-by: Songkan Tang <[email protected]> * Update change log Signed-off-by: Songkan Tang <[email protected]> * Add independent GeneratePopoverBody ut and reorgnize constants Signed-off-by: Songkan Tang <[email protected]> * Simplify states of loading to get summary process Signed-off-by: Songkan Tang <[email protected]> * Make IncontextInsight not shareable and each component has its own IncontextInsight Signed-off-by: Songkan Tang <[email protected]> * Enable context aware alert only if feature flag is enabled Signed-off-by: Songkan Tang <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Songkan Tang <[email protected]> Co-authored-by: Hailong Cui <[email protected]>

Hailong-am and others added 3 commits July 12, 2024 14:01

support context aware alert analysis

5c2c066

Signed-off-by: Hailong Cui <[email protected]>

Render GeneratePopover IncontextInsight component as a button to gene…

0043748

…rate summary Signed-off-by: Songkan Tang <[email protected]>

Remove hardcoded assistant role from the parameter payload

8f3aca3

Signed-off-by: Songkan Tang <[email protected]>

songkant-aws requested review from lezzago, joshuali925, anirudha, ruanyl, SuZhou-Joe, xluo-aws, gaobinlong, Hailong-am, wanglam and raintygao as code owners July 12, 2024 06:38

wanglam reviewed Jul 12, 2024

View reviewed changes

common/types/chat_saved_object_attributes.ts Outdated Show resolved Hide resolved

server/services/chat/olly_chat_service.ts Outdated Show resolved Hide resolved

server/routes/chat_routes.ts Show resolved Hide resolved

wanglam reviewed Jul 12, 2024

View reviewed changes

public/components/incontext_insight/index.tsx Outdated Show resolved Hide resolved

wanglam reviewed Jul 12, 2024

View reviewed changes

public/components/incontext_insight/index.tsx Outdated Show resolved Hide resolved

songkant-aws added 2 commits July 16, 2024 14:38

Make GeneratePopoverBody as independent component

78ff2d3

Signed-off-by: Songkan Tang <[email protected]>

Update change log

493d5cf

Signed-off-by: Songkan Tang <[email protected]>

wanglam added v2.16.0 backport 2.x Trigger the backport flow to 2.x labels Jul 16, 2024

wanglam reviewed Jul 16, 2024

View reviewed changes

Add independent GeneratePopoverBody ut and reorgnize constants

50b35ab

Signed-off-by: Songkan Tang <[email protected]>

wanglam reviewed Jul 17, 2024

View reviewed changes

public/components/incontext_insight/generate_popover_body.tsx Show resolved Hide resolved

songkant-aws added 4 commits July 17, 2024 15:11

Simplify states of loading to get summary process

d85c953

Signed-off-by: Songkan Tang <[email protected]>

Merge branch 'opensearch-project:main' into context-aware-alert-analysis

9dff42f

Make IncontextInsight not shareable and each component has its own In…

8c0c9b3

…contextInsight Signed-off-by: Songkan Tang <[email protected]>

Enable context aware alert only if feature flag is enabled

43d666e

Signed-off-by: Songkan Tang <[email protected]>

songkant-aws force-pushed the context-aware-alert-analysis branch from 514c5ca to 43d666e Compare July 22, 2024 08:50

Hailong-am removed the v2.16.0 label Jul 23, 2024

wanglam approved these changes Jul 24, 2024

View reviewed changes

Hailong-am approved these changes Jul 24, 2024

View reviewed changes

Merge branch 'main' into context-aware-alert-analysis

577a0a9

Signed-off-by: Songkan Tang <[email protected]>

raintygao approved these changes Jul 24, 2024

View reviewed changes

songkant-aws and others added 2 commits July 31, 2024 11:27

Merge branch 'main' into context-aware-alert-analysis

246547c

Signed-off-by: Songkan Tang <[email protected]>

Merge branch 'main' into context-aware-alert-analysis

20c6a9e

Hailong-am added the v2.17.0 label Jul 31, 2024

Hailong-am merged commit 32888dd into opensearch-project:main Jul 31, 2024
11 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 31, 2024

[Backport 2.x] Initial implementation of context aware alert analysis #249

Closed

dblock mentioned this pull request Aug 5, 2024

[FEATURE] Support context aware alert analysis #214

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of context aware alert analysis #215

Initial implementation of context aware alert analysis #215

songkant-aws commented Jul 12, 2024 •

edited

Loading

wanglam commented Jul 12, 2024

songkant-aws commented Jul 16, 2024 •

edited

Loading

wanglam left a comment

Hailong-am left a comment •

edited

Loading

songkant-aws commented Jul 24, 2024

raintygao commented Jul 24, 2024

songkant-aws commented Jul 24, 2024

Initial implementation of context aware alert analysis #215

Initial implementation of context aware alert analysis #215

Conversation

songkant-aws commented Jul 12, 2024 • edited Loading

Description

Issues Resolved

Check List

wanglam commented Jul 12, 2024

songkant-aws commented Jul 16, 2024 • edited Loading

wanglam left a comment

Choose a reason for hiding this comment

Hailong-am left a comment • edited Loading

Choose a reason for hiding this comment

songkant-aws commented Jul 24, 2024

raintygao commented Jul 24, 2024

songkant-aws commented Jul 24, 2024

songkant-aws commented Jul 12, 2024 •

edited

Loading

songkant-aws commented Jul 16, 2024 •

edited

Loading

Hailong-am left a comment •

edited

Loading