fix: keep in history list after history deleted #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
…(#10) * feat: change implementation of basic_input_output to built-in parser Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable build input-output message Signed-off-by: SuZhou-Joe <[email protected]> * feat: sort interactions Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: use parent_interaction_id as traceId Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
* feat: add mechannism to register messageParser Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add interaction into message_bubble.tsx Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * fix: lint checker Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
* Integrate Memeory APIs of agent framework Signed-off-by: gaobinlong <[email protected]> * Add TODO to getSessions() Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]>
* feat: add implement visualization in customized parser Signed-off-by: SuZhou-Joe <[email protected]> * feat: add csv-parser lib Signed-off-by: SuZhou-Joe <[email protected]> * feat: add csv-parser lib Signed-off-by: SuZhou-Joe <[email protected]> * feat: add test cases Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
reviewed
Nov 29, 2023
Comment on lines
+81
to
+84
| // Clear old session chat states | ||
| setTitle(undefined); | ||
| setSessionId(undefined); | ||
| chatStateDispatch({ type: 'reset' }); |
There was a problem hiding this comment.
What about adding a unit test to cover the changes here?
There was a problem hiding this comment.
Is that means add unit tests for the whole ChatHIstoryPage?
There was a problem hiding this comment.
That would be better. We are fixing an edge case in this PR, preparing a dedicated unit test for it can prevent others stepping into the same issue if they do any refactor.
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
reviewed
Nov 29, 2023
test/__mocks__/fileMock.js
Outdated
There was a problem hiding this comment.
Yes. These two files are used in https://github.com/opensearch-project/dashboards-assistant/blob/feature/agent-framework/test/jest.config.js#L28-L30 . The test will be failed if import sass or svg files.
SuZhou-Joe
approved these changes
Nov 30, 2023
wanglam
changed the base branch from
feature/agent-framework
to
feature/langchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix jump to new chat page after current session deleted in dock right mode like below video:
Screen.Recording.2023-11-29.at.14.41.57.mov
It should stay the same page
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.