Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor: get root agent id by calling api (#128) #129

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Feb 4, 2024

Description

Backport #128 to 2.x

Issues Resolved

#127

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Refactor: get root agent id by calling api

Signed-off-by: gaobinlong <[email protected]>

* Modify change log

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit a356031)
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4fc285) 95.66% compared to head (165599e) 95.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x     #129      +/-   ##
==========================================
- Coverage   95.66%   95.63%   -0.03%     
==========================================
  Files          48       48              
  Lines        1268     1261       -7     
  Branches      314      312       -2     
==========================================
- Hits         1213     1206       -7     
  Misses         53       53              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong gaobinlong merged commit b11ff40 into opensearch-project:2.x Feb 4, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants