Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix History button position #113

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

raintygao
Copy link
Collaborator

@raintygao raintygao commented Jan 26, 2024

Description

fix History button position
img_v3_027i_b2a4ccc9-d41c-477c-8e98-64f8bb7d5e4g
Before

img_v3_027i_46179644-f942-45d1-a26b-ac83802440bg
After

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e045d11) 95.31% compared to head (25bd373) 95.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          47       47           
  Lines        1260     1260           
  Branches      304      304           
=======================================
  Hits         1201     1201           
  Misses         57       57           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have a screenshot of this change?

@raintygao
Copy link
Collaborator Author

could we have a screenshot of this change?

Done.

@raintygao raintygao merged commit e28d020 into opensearch-project:main Jan 29, 2024
11 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 29, 2024
Signed-off-by: tygao <[email protected]>
(cherry picked from commit e28d020)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Jan 29, 2024
(cherry picked from commit e28d020)

Signed-off-by: tygao <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants