feat: change implementation of basic_input_output to built-in parser #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuali925
approved these changes
Nov 21, 2023
| let finalMessages: IMessage[] = []; | ||
| for (const interaction of allInteractions) { | ||
| finalMessages = [...finalMessages, ...(await messageParserRunner.run(interaction))]; | ||
| } |
There was a problem hiding this comment.
i thought agent framework will provide a field in the memory to store parsed messages, or the parsing will happen in some opensearch plugin, instead of parsing every time on session load?
There was a problem hiding this comment.
Actually agent framework thought messages are a Frontend concept, and different Frontend integration may parse interaction into different messages. So they will only store the interactions and for messages, yes, they will be built every time.
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/build-output-message
branch
from
477459f to
73f4631
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
changed the base branch from
feature/add-builder-registration
to
feature/agent-framework
SuZhou-Joe
added a commit
that referenced
this pull request
Nov 23, 2023
…10) * feat: change implementation of basic_input_output to built-in parser Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable build input-output message Signed-off-by: SuZhou-Joe <[email protected]> * feat: sort interactions Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: use parent_interaction_id as traceId Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Dec 1, 2023
…10) * feat: change implementation of basic_input_output to built-in parser Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable build input-output message Signed-off-by: SuZhou-Joe <[email protected]> * feat: sort interactions Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: use parent_interaction_id as traceId Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
added a commit
that referenced
this pull request
Dec 5, 2023
…10) * feat: change implementation of basic_input_output to built-in parser Signed-off-by: SuZhou-Joe <[email protected]> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <[email protected]> * feat: enable build input-output message Signed-off-by: SuZhou-Joe <[email protected]> * feat: sort interactions Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless code Signed-off-by: SuZhou-Joe <[email protected]> * feat: use parent_interaction_id as traceId Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.