fix: disable top input when no access

Signed-off-by: Lin Wang <[email protected]>
opensearch-project · Dec 27, 2023 · 810d5fe · 810d5fe
1 parent 510b685
commit 810d5fe
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/public/chat_header_button.test.tsx b/public/chat_header_button.test.tsx
@@ -159,4 +159,39 @@ describe('<HeaderChatButton />', () => {
     });
     expect(screen.getByLabelText('chat input')).toHaveFocus();
   });
+
+  it('should disable chat input when no access', () => {
+    render(
+      <HeaderChatButton
+        application={applicationServiceMock.createStartContract()}
+        userHasAccess={false}
+        contentRenderers={{}}
+        actionExecutors={{}}
+        assistantActions={{} as AssistantActions}
+        currentAccount={{ username: 'test_user', tenant: 'test_tenant' }}
+      />
+    );
+    expect(screen.getByLabelText('chat input')).toBeDisabled();
+  });
+
+  it('should not focus on chat input when no access and pressing global shortcut', () => {
+    render(
+      <HeaderChatButton
+        application={applicationServiceMock.createStartContract()}
+        userHasAccess={false}
+        contentRenderers={{}}
+        actionExecutors={{}}
+        assistantActions={{} as AssistantActions}
+        currentAccount={{ username: 'test_user', tenant: 'test_tenant' }}
+      />
+    );
+    expect(screen.getByLabelText('chat input')).not.toHaveFocus();
+    fireEvent.keyDown(document.body, {
+      key: '/',
+      code: 'NumpadDivide',
+      charCode: 111,
+      metaKey: true,
+    });
+    expect(screen.getByLabelText('chat input')).not.toHaveFocus();
+  });
 });
diff --git a/public/chat_header_button.tsx b/public/chat_header_button.tsx
@@ -124,6 +124,9 @@ export const HeaderChatButton = (props: HeaderChatButtonProps) => {
   };
 
   useEffect(() => {
+    if (!props.userHasAccess) {
+      return;
+    }
     const onGlobalMouseUp = (e: KeyboardEvent) => {
       if (e.metaKey && e.key === '/') {
         inputRef.current?.focus();
@@ -134,7 +137,7 @@ export const HeaderChatButton = (props: HeaderChatButtonProps) => {
     return () => {
       document.removeEventListener('keydown', onGlobalMouseUp);
     };
-  }, []);
+  }, [props.userHasAccess]);
 
   return (
     <>
@@ -179,6 +182,7 @@ export const HeaderChatButton = (props: HeaderChatButtonProps) => {
               )}
             </span>
           }
+          disabled={!props.userHasAccess}
         />
       </div>
       <ChatContext.Provider value={chatContextValue}>