Revert "feat: only support visual editor alerts to navigate to discov…

…er (#368) (#370)" This reverts commit 2ba4853. Signed-off-by: tygao <[email protected]>
opensearch-project · Nov 11, 2024 · 29fbf69 · 29fbf69
1 parent 2ba4853
commit 29fbf69
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 58 deletions.
diff --git a/public/components/incontext_insight/generate_popover_body.test.tsx b/public/components/incontext_insight/generate_popover_body.test.tsx
@@ -338,7 +338,6 @@ describe('GeneratePopoverBody', () => {
         index: 'mock_index',
         dataSourceId: `test-data-source-id`,
         monitorType: 'query_level_monitor',
-        isVisualEditorMonitor: true,
       },
     });
     mockPost.mockImplementation((path: string, body) => {
@@ -385,56 +384,4 @@ describe('GeneratePopoverBody', () => {
     });
     expect(window.open).toHaveBeenCalledWith('formattedUrl', '_blank');
   });
-
-  it('should hide navigate to discover if not from visual editor monitor', async () => {
-    incontextInsightMock.contextProvider = jest.fn().mockResolvedValue({
-      additionalInfo: {
-        dsl: mockDSL,
-        index: 'mock_index',
-        dataSourceId: `test-data-source-id`,
-        monitorType: 'query_level_monitor',
-        isVisualEditorMonitor: false,
-      },
-    });
-    mockPost.mockImplementation((path: string, body) => {
-      let value;
-      switch (path) {
-        case SUMMARY_ASSISTANT_API.SUMMARIZE:
-          value = {
-            summary: 'Generated summary content',
-            insightAgentIdExists: true,
-          };
-          break;
-
-        case SUMMARY_ASSISTANT_API.INSIGHT:
-          value = 'Generated insight content';
-          break;
-
-        default:
-          return null;
-      }
-      return Promise.resolve(value);
-    });
-
-    const coreStart = coreMock.createStart();
-    const dataStart = dataPluginMock.createStartContract();
-    const getStartServices = jest.fn().mockResolvedValue([
-      coreStart,
-      {
-        data: dataStart,
-      },
-    ]);
-    const { queryByText } = render(
-      <GeneratePopoverBody
-        incontextInsight={incontextInsightMock}
-        httpSetup={mockHttpSetup}
-        closePopover={closePopoverMock}
-        getStartServices={getStartServices}
-      />
-    );
-
-    await waitFor(() => {
-      expect(queryByText('Discover details')).not.toBeInTheDocument();
-    });
-  });
 });
diff --git a/public/components/incontext_insight/generate_popover_body.tsx b/public/components/incontext_insight/generate_popover_body.tsx
@@ -58,11 +58,6 @@ export const GeneratePopoverBody: React.FC<{
       if (!contextObject) return;
       const monitorType = contextObject?.additionalInfo?.monitorType;
       const dsl = contextObject?.additionalInfo?.dsl;
-      const isVisualEditorMonitor = contextObject?.additionalInfo?.isVisualEditorMonitor;
-      // Only alerts from visual editor monitor support to navigate to discover.
-      if (!isVisualEditorMonitor) {
-        return;
-      }
       // Only this two types from alerting contain DSL and index.
       const isSupportedMonitorType =
         monitorType === 'query_level_monitor' || monitorType === 'bucket_level_monitor';