Address review comments

Signed-off-by: Hailong Cui <[email protected]>
opensearch-project · Dec 11, 2023 · 21e4ead · 21e4ead
1 parent 9ac427f
commit 21e4ead
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/public/chat_header_button.tsx b/public/chat_header_button.tsx
@@ -65,9 +65,7 @@ export const HeaderChatButton: React.FC<HeaderChatButtonProps> = (props) => {
       selectedTabId,
       preSelectedTabId,
       setSelectedTabId: (tabId: TabId) => {
-        if (selectedTabId !== tabId) {
-          setPreSelectedTabId(selectedTabId);
-        }
+        setPreSelectedTabId(selectedTabId);
         setSelectedTabId(tabId);
       },
       flyoutVisible,

diff --git a/public/hooks/use_chat_actions.tsx b/public/hooks/use_chat_actions.tsx
@@ -138,7 +138,9 @@ export const useChatActions = (): AssistantActions => {
 
       case 'view_trace':
         if ('traceId' in message) {
-          chatContext.setSelectedTabId('trace');
+          if (chatContext.selectedTabId !== TAB_ID.TRACE) {
+            chatContext.setSelectedTabId(TAB_ID.TRACE);
+          }
           chatContext.setTraceId(message.traceId);
         }
         break;