Refactor: Migrate files from 'ad' to 'timeseries' package

[kaituo]

Description

This commit involves moving various files from the 'ad' package to the 'timeseries' package. All changes to dependent imports were handled automatically through the IDE, and no changes to file contents were made in the process.

Testing done:

• gradle build

Issues Resolved

#866

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[sudiptoguha]

This name is outside the "TimeSeries" pattern -- is that intended?

[kaituo]

What do you mean by "outside the "TimeSeries" pattern"? The change renamed from NotSerializedADExceptionName to NotSerializedExceptionName.

[sudiptoguha]

DetectionDateRange was in the same package/internal class?

[sudiptoguha]

Ok, got it - you now need to reference this externally?

[kaituo]

yes, since I changed

src/main/java/org/opensearch/ad/model/DetectionDateRange.java

to

./src/main/java/org/opensearch/timeseries/model/DateRange.java

[sudiptoguha]

isNullOrEmpty is standard though -- is the util class being deprecated? Or is there a nuance in the definitions?

[kaituo]

isNullOrEmpty is commonly used to check if a string is null or empty.

Good catch. The util class is not deprecated. Will move ParseUtils to util package.

[sudiptoguha]

would spotless complain about the formatting later?

[kaituo]

seems like the change is from spotless :)

[sudiptoguha]

Spotless may complain down the road ...

[kaituo]

I ran spotless before sending a commit. Don't expect spotless will fail me :)

[sudiptoguha]

:)

[codecov]

Codecov Report

Merging #918 (e13bb72) into main (472868d) will increase coverage by 0.10%.
The diff coverage is 68.11%.

@@             Coverage Diff              @@
##               main     #918      +/-   ##
============================================
+ Coverage     79.18%   79.28%   +0.10%     
- Complexity     4353     4363      +10     
============================================
  Files           319      319              
  Lines         18281    18280       -1     
  Branches       1907     1907              
============================================
+ Hits          14475    14494      +19     
+ Misses         2892     2873      -19     
+ Partials        914      913       -1     

Flag	Coverage Δ
plugin	79.28% <68.11%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorJobRunner.java	80.50% <0.00%> (ø)
.../java/org/opensearch/ad/AnomalyDetectorRunner.java	43.52% <ø> (ø)
...in/java/org/opensearch/ad/EntityProfileRunner.java	75.82% <ø> (ø)
src/main/java/org/opensearch/ad/MemoryTracker.java	79.78% <ø> (ø)
.../main/java/org/opensearch/ad/NodeStateManager.java	75.49% <ø> (-1.99%)	⬇️
...java/org/opensearch/ad/cluster/ADDataMigrator.java	79.08% <ø> (ø)
.../main/java/org/opensearch/ad/cluster/HashRing.java	81.78% <0.00%> (ø)
...a/org/opensearch/ad/feature/AbstractRetriever.java	82.85% <ø> (ø)
.../org/opensearch/ad/feature/CompositeRetriever.java	82.17% <ø> (ø)
...java/org/opensearch/ad/feature/FeatureManager.java	96.07% <ø> (ø)
... and 69 more

... and 1 file with indirect coverage changes

[sudiptoguha]

Looks good.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-918-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee04225349a5f0f003d56e77a3243386f4a9673d
# Push it to GitHub
git push --set-upstream origin backport/backport-918-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-918-to-2.x.