-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cross-cluster monitor cluster setting #1612
Enable cross-cluster monitor cluster setting #1612
Conversation
Signed-off-by: Megha Goyal <[email protected]>
Approving assuming CI passes. |
Backporting back to v2.14 as the feature received GA launch approval after 2.13 open source release. |
The failing test is That test suite has a helper function which should be toggling the feature on/off; but it looks like it's failing to disable to feature before the start of that test. Troubleshooting that test. |
fc80782
to
d40fa66
Compare
Signed-off-by: Megha Goyal <[email protected]>
d40fa66
to
478eb46
Compare
Fixed in commit 478eb46 |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1612-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c69e091c81f585ebf5a1e96bfab862dab990191
# Push it to GitHub
git push --set-upstream origin backport-1612-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.14
# Create a new branch
git switch --create backport-1612-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c69e091c81f585ebf5a1e96bfab862dab990191
# Push it to GitHub
git push --set-upstream origin backport-1612-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.14 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.15
# Create a new branch
git switch --create backport-1612-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c69e091c81f585ebf5a1e96bfab862dab990191
# Push it to GitHub
git push --set-upstream origin backport-1612-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.15 Then, create a pull request where the |
Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]>
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit f0ff930) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit f0ff930) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit f0ff930) Signed-off-by: Megha Goyal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Megha Goyal <[email protected]> (cherry picked from commit f0ff930) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit f0ff930) Signed-off-by: Megha Goyal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Issue #, if available:
Description of changes:
Enable cross-cluster monitor cluster setting
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.