Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Change INDEX_SEARCHER threadpool to auto queue to support task resource tracking #7765

Merged
merged 1 commit into from
May 25, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented May 25, 2023

Description

Backports #7502

Concurrent segment search has been backported to 2.x so we also need to backport #7502 so that we are not missing out on resource tracking whenever concurrent search is GA.

Since Resizable threadpool type does not exist in 2.x, we will use the same auto queue threadpool type that search threadpool uses in 2.x.

Ref #7613

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Resolves #7743

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…ort task resource tracking (opensearch-project#7502)

(cherry picked from commit 054cccd)

Signed-off-by: Jay Deng <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@jed326
Copy link
Collaborator Author

jed326 commented May 25, 2023

@reta this is the backport for #7502 which you previously helped approved. Could you please take a look? Thanks!

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #7765 (484565d) into 2.x (bb10bdf) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x    #7765      +/-   ##
============================================
- Coverage     70.56%   70.53%   -0.03%     
+ Complexity    56409    56372      -37     
============================================
  Files          4665     4665              
  Lines        267683   267683              
  Branches      39638    39638              
============================================
- Hits         188885   188810      -75     
- Misses        62512    62607      +95     
+ Partials      16286    16266      -20     
Impacted Files Coverage Δ
...ain/java/org/opensearch/threadpool/ThreadPool.java 83.09% <0.00%> (-0.88%) ⬇️

... and 449 files with indirect coverage changes

@jed326
Copy link
Collaborator Author

jed326 commented May 25, 2023

Flaky test looks like #6761

@reta reta merged commit bbbe203 into opensearch-project:2.x May 25, 2023
@jed326 jed326 deleted the 2.x branch June 5, 2023 20:25
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants