Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Optimize innerhits query performance #17084

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[Backport 2.x] Optimize innerhits query performance #17084

merged 1 commit into from
Jan 22, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 92088be from #16937.

@github-actions
Optimize innerhits query performance (#16937)
d67b79b 
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
(cherry picked from commit 92088be)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d67b79b: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d67b79b: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (bd885f7) to head (d67b79b).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...va/org/opensearch/index/mapper/DocumentMapper.java 0.00% 15 Missing ⚠️
...n/java/org/opensearch/search/fetch/FetchPhase.java 0.00% 6 Missing ⚠️
...org/opensearch/index/query/NestedQueryBuilder.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17084      +/-   ##
============================================
+ Coverage     71.84%   71.90%   +0.05%     
- Complexity    65595    65625      +30     
============================================
  Files          5318     5318              
  Lines        305846   305851       +5     
  Branches      44602    44603       +1     
============================================
+ Hits         219739   219911     +172     
+ Misses        67752    67631     -121     
+ Partials      18355    18309      -46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 merged commit 73e1b92 into 2.x Jan 22, 2025
60 of 62 checks passed
@github-actions github-actions bot deleted the backport/backport-16937-to-2.x branch January 22, 2025 19:20
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrross @jed326